Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SingleMainWindow to true for Linux #201

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Nov 10, 2024

Enforces single instance on Linux.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This feature is now incorporated into menuinst=2.2.0 (conda/menuinst#265).
I'm not certain yet whether including it here will raise an error for menuinst=2.1.2 or just be ineffective.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 10, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@mrclary mrclary marked this pull request as ready for review November 12, 2024 07:06
@mrclary
Copy link
Contributor Author

mrclary commented Nov 12, 2024

@conda-forge-admin, please rerender

@mrclary
Copy link
Contributor Author

mrclary commented Nov 12, 2024

@ccordoba12, I've checked this artifact on my Ubuntu VM and found that the additional tag in the json file is gracefully ignored by menuinst 2.1.2, so we can safely merge this. The feature will only be recognized after updating to menuinst >=2.2.0.

Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@ccordoba12 ccordoba12 changed the title Set SingleMainWindow to true for Linux. Set SingleMainWindow to true for Linux Nov 18, 2024
@ccordoba12 ccordoba12 merged commit d115919 into conda-forge:main Nov 18, 2024
9 checks passed
@mrclary mrclary deleted the single-window branch November 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants