Add file type association to Spyder shortcuts on all platforms. #171

mrclary · 2024-05-13T17:27:18Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda/menuinst#117
conda/menuinst#183
conda/menuinst#225

Requires menuinst >= 2.1.2

conda-forge-webservices · 2024-05-13T17:27:25Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ccordoba12 · 2024-05-13T17:57:58Z

This is great! Thanks @mrclary for working on it.

Quick question: how does this work on Windows?

mrclary · 2024-05-13T18:11:45Z

I'm not sure how this works on Windows. I think @jaimergp is still working out some issues. Nevertheless, I wanted to create this draft PR so that I did not forget about it.

ccordoba12

This looks good to me, thanks @mrclary!

I only have a quick question for you: did you manually test these changes on Windows, Linux and Mac? It's not clear if you already did it.

mrclary · 2024-06-28T01:00:43Z

Not yet on Windows and Linux. But I'll do that and report back.

mrclary · 2024-06-29T03:54:05Z

There appear to be some bugs with menuinst >= 2.1, so we could hold off on this for a bit more.

conda-forge-webservices · 2024-07-24T18:57:34Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

mrclary · 2024-07-28T21:32:55Z

@jaimergp, do you know when the next menuinst version will be released?

Array options for script and cat-ing to script are incompatible: ("-i" "''" "-e") works for cat-ing but not for script; ("-i" '' "-e") works for script but not cat-ing. For situations that require both script and cat-ing that must work for both GNU and BSD, the only solution is to use "-i.bak -e" and "rm *.bak"

Note: this results in a non-functioning application bundle, with nested application and broken executable stubs (conda/menuinst#179)

Note: this does not appear to establish file type association (conda/menuinst#185)

Note: I don't think this is a comprehensive list

conda-build copies cli-64.exe and spyder-script.py to the Scripts directory after bld.bat is run, so we must copy gui-64.exe such that it does not get clobbered, then use the post-link script to clean things up. This work-around may be removed in the future if/when conda-build adds a feature to specify which executable stub to use. Hopefully, the resulting spyder.exe will also get the Spyder icon.

ccordoba12

A few questions and suggestions for you @mrclary.

recipe/meta.yaml

ccordoba12 · 2024-08-16T02:15:44Z

recipe/bld.bat

 for /F "delims=. tokens=1" %%i in ("%PKG_VERSION%") do set PKG_MAJOR_VER=%%i
+call :replace spyder-menu.json spyder-menu.json


Is this replacement correct? Shouldn't it be replacing a .bak file, like in the line just below this one?

:replace reads the lines in the first file and replaces the __PKG_VERSION__ tokens with the major version number, then writes the lines to the second file. The default json file is for menuinst v2, so we just write back to the same file. Any *.json file will be executed by menuinst, so on the line below we also need to rename the spyder-menu-v1.json file so that menuinst does not try to execute on it. The post-link.bat script will determine whether v1 or v2 is in the base environment, and swap them if needed.

But perhaps it would be clearer to just have both files spyder-menu-v1.json and spyder-menu-v2.json, then let post-link.bat add .bak to the unnecessary file.

Actually, the file names in the Menu directory should not change on install so that they will all be removed on uninstall. So it will be best to have spyder-menu-v1.json.bak and spyder-menu.json. Then copy v1 to spyder-menu.json (overwriting) only if necessary.

ccordoba12 · 2024-08-16T02:17:21Z

recipe/bld.bat

-del %SCRIPTS%\spyder_win_post_install.py
-del %SCRIPTS%\spyder.bat
-del %SCRIPTS%\spyder


Why are not we removing these scripts now? I think they shouldn't be part of the package.

I agree that they should not be part of the package. I removed these lines because these files were not being added to the %SCRIPTS% directory, so I assumed they were tech-debt. However, I can double check.

Yes, I've confirmed that these files are not in the Scripts directory of the conda package (or anywhere else). Only the following:

Scripts/.spyder-post-link.bat Scripts/gui-64.exe Scripts/spyder-script.py Scripts/spyder-script.pyw Scripts/spyder.exe Scripts/spyder.ico

ccordoba12 · 2024-08-16T02:20:06Z

recipe/spyder-script.pyw

Why is this script necessary now?

This is required for Spyder to be listed as an application for file types in context menus. Windows looks at the shortcut executable for this, so when using pythonw.exe spyder-script.py, Spyder shows up as Python. In order to fix this, the shortcut must use the spyder.exe executable stub, but this executable stub looks for spyder-script.pyw rather than spyder-script.py.

See:
conda/menuinst#185 (comment)
conda/menuinst#185 (comment)
conda/menuinst#185 (comment)

recipe/spyder-script.pyw

….bak extension

Co-authored-by: Carlos Cordoba <[email protected]>

ccordoba12 · 2024-08-20T15:33:59Z

This is ready to be merged, right @mrclary?

mrclary · 2024-08-20T15:36:59Z

Yes, if you are happy with my responses to your comments.
There is also spyder-ide/spyder#22362 that should be ready.

ccordoba12 · 2024-08-20T15:39:43Z

Yes, if you are happy with my responses to your comments.

Yep, I am. Let's merge it then.

mrclary mentioned this pull request May 13, 2024

Conda-based Installer Parent Issue spyder-ide/spyder#20001

Closed

16 tasks

mrclary force-pushed the file-type-association branch from c806cab to fed2c5a Compare May 13, 2024 18:28

mrclary force-pushed the file-type-association branch from fed2c5a to 78cb899 Compare June 22, 2024 22:25

mrclary marked this pull request as ready for review June 27, 2024 23:11

mrclary requested review from andfoy, ccordoba12, dalthviz and steff456 as code owners June 27, 2024 23:11

ccordoba12 reviewed Jun 27, 2024

View reviewed changes

mrclary marked this pull request as draft June 29, 2024 03:52

mrclary force-pushed the file-type-association branch 2 times, most recently from dd592ab to 5d41802 Compare July 4, 2024 18:00

mrclary force-pushed the file-type-association branch from 5d41802 to 23a6501 Compare July 16, 2024 17:29

mrclary force-pushed the file-type-association branch from 23a6501 to d313ea8 Compare July 24, 2024 18:57

mrclary added 9 commits August 9, 2024 15:19

Add file type association for macOS.

eb7a43c

Note: this results in a non-functioning application bundle, with nested application and broken executable stubs (conda/menuinst#179)

Add file type association for Windows.

ead6868

Note: this does not appear to establish file type association (conda/menuinst#185)

Add file type association for Linux.

4cc1cb7

Note: I don't think this is a comprehensive list

Try "." in extensions

f423944

Requires menuinst >=2.1

5ed1118

Menuinst >2.1 includes option for base/non-base environment names

92ea0b8

Create subroutine for replacing variables in menu file

af6d6a0

Linux shortcut command requires "%F" rather than "$@".

2b7de75

mrclary force-pushed the file-type-association branch from d313ea8 to 2b7de75 Compare August 9, 2024 22:21

ccordoba12 marked this pull request as ready for review August 15, 2024 20:57

ccordoba12 reviewed Aug 16, 2024

View reviewed changes

mrclary and others added 3 commits August 19, 2024 15:09

Do not rename v1 json file during find/replace text, just start with …

1daf0b5

….bak extension

Update menuinst to 2.1.2

a0952b8

Apply suggestions from code review

0dd6882

Co-authored-by: Carlos Cordoba <[email protected]>

ccordoba12 merged commit 39475fe into conda-forge:dev Aug 20, 2024
26 checks passed

mrclary deleted the file-type-association branch August 20, 2024 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add file type association to Spyder shortcuts on all platforms. #171

Add file type association to Spyder shortcuts on all platforms. #171

mrclary commented May 13, 2024 •

edited

Loading

conda-forge-webservices bot commented May 13, 2024

ccordoba12 commented May 13, 2024

mrclary commented May 13, 2024

ccordoba12 left a comment

mrclary commented Jun 28, 2024

mrclary commented Jun 29, 2024

conda-forge-webservices bot commented Jul 24, 2024

mrclary commented Jul 28, 2024

ccordoba12 left a comment

ccordoba12 Aug 16, 2024

mrclary Aug 16, 2024

mrclary Aug 20, 2024

ccordoba12 Aug 16, 2024

mrclary Aug 16, 2024

mrclary Aug 20, 2024

ccordoba12 Aug 16, 2024

mrclary Aug 16, 2024

ccordoba12 commented Aug 20, 2024

mrclary commented Aug 20, 2024

ccordoba12 commented Aug 20, 2024

		for /F "delims=. tokens=1" %%i in ("%PKG_VERSION%") do set PKG_MAJOR_VER=%%i
		call :replace spyder-menu.json spyder-menu.json

Add file type association to Spyder shortcuts on all platforms. #171

Add file type association to Spyder shortcuts on all platforms. #171

Conversation

mrclary commented May 13, 2024 • edited Loading

conda-forge-webservices bot commented May 13, 2024

ccordoba12 commented May 13, 2024

mrclary commented May 13, 2024

ccordoba12 left a comment

Choose a reason for hiding this comment

mrclary commented Jun 28, 2024

mrclary commented Jun 29, 2024

conda-forge-webservices bot commented Jul 24, 2024

mrclary commented Jul 28, 2024

ccordoba12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccordoba12 commented Aug 20, 2024

mrclary commented Aug 20, 2024

ccordoba12 commented Aug 20, 2024

mrclary commented May 13, 2024 •

edited

Loading