-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #15
Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #15
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please re-render. |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Appears this is unintentionally being included along with `_FORTIFY_SOURCE 2`, which is causing some compilation errors. So strip this flag from `CPPFLAGS` and readd it to the beginning where it should not cause this problem.
then | ||
export CPPFLAGS=$(echo "${CPPFLAGS}" | sed -E "s@ \-mmacosx\-version\-min=${MACOSX_DEPLOYMENT_TARGET}@@g") | ||
export CPPFLAGS="-mmacosx-version-min=${MACOSX_DEPLOYMENT_TARGET} ${CPPFLAGS}" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised issue ( AnacondaRecipes/aggregate#107 ) to address this more elegantly.
recipe/meta.yaml
Outdated
@@ -29,6 +29,7 @@ requirements: | |||
test: | |||
requires: | |||
- clangdev | |||
- ld64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into this error during testing. Saw this Clang OpenMP MacPorts issue, which notes the same issue is resolved by using ld64
linker. So gave that a try here, but it seems it is not being used for the test. Not sure what the best way to update this test is.
Any thoughts on how best to move this forward, @isuruf? |
Try adding |
98e79e8
to
119cdc9
Compare
Hmm...can't seem to get it to work, but maybe I'm not doing it right. Would you be able to take a look? |
Why is this missing stdlib? |
@hmaarrfk maybe try the workaround mentioned at: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129#c6 ? |
yes, this looks similar... i set the two variables mentioned... @mingwandroid should we backport the patch? /edit: it seems more of acmake issue at this point.. |
@gabm, which patch is that? AFAICT, openmp is wrong here, adding flags of |
I really don't get how this flag is being passed. It seems to be something earlier in the stack than openmp. The openmp install files have no mention of Maybe somebody can make sense of Linuxbrew's solution's: |
@conda-forge-admin please rerender and pray! |
@conda-forge-admin please rerender |
…nda-forge-pinning 2019.01.29
It is likely this feedstock needs to be rebuilt.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
vic
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one.This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!