-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for pugixml114 redux #12
Conversation
…nda-forge-pinning 2023.11.10.07.51.14
…nda-forge-pinning 2024.06.19.13.02.02
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much investment in the conda build. I looked through the commits and I didn't see anything alarming. If it works for you then that's good enough for me.
Yeah it's really just two lines changed by me (stdlib line and c++11 line) the rest is from #11 so should be good to go |
IIRC 1.16.2 uses C++14 features, but maybe it was just C++11 feature that were not fully supported by the compilers at the time. Then again I think it is overridden in the |
Looks a commit June 12 2023 removed a conditional based on MSVC_VERSION that probably changed it from being set only on Windows to having it be set on all systems, and 1.16.2 came out May 27, 2023 -- that could explain why we need to set something here, and suggests it could be removed once But in any case yes one of you two just needs to click the green button now! |
Checklist
Reset the build number to0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Trying to take over #11
Closes #11