Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for pugixml114 redux #12

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Rebuild for pugixml114 redux #12

merged 8 commits into from
Jun 20, 2024

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Jun 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Trying to take over #11

Closes #11

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [16]

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@larsoner
Copy link
Contributor Author

@cboulay @tstenner should be good go merge here! (FYI I want this so that liblsl is compatible with VTK 9.3 that just came out, e.g. here).

@larsoner larsoner mentioned this pull request Jun 19, 2024
Copy link
Contributor

@cboulay cboulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much investment in the conda build. I looked through the commits and I didn't see anything alarming. If it works for you then that's good enough for me.

@larsoner
Copy link
Contributor Author

Yeah it's really just two lines changed by me (stdlib line and c++11 line) the rest is from #11 so should be good to go

@tstenner
Copy link
Contributor

IIRC 1.16.2 uses C++14 features, but maybe it was just C++11 feature that were not fully supported by the compilers at the time. Then again I think it is overridden in the CMakeLists.txt, so it shouldn't break anything.

@larsoner
Copy link
Contributor Author

Then again I think it is overridden in the CMakeLists.txt, so it shouldn't break anything.

Looks a commit June 12 2023 removed a conditional based on MSVC_VERSION that probably changed it from being set only on Windows to having it be set on all systems, and 1.16.2 came out May 27, 2023 -- that could explain why we need to set something here, and suggests it could be removed once >1.16.2 lands.

But in any case yes one of you two just needs to click the green button now!

@cboulay cboulay merged commit 941497d into conda-forge:main Jun 20, 2024
6 checks passed
@larsoner larsoner deleted the rebuild branch June 20, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants