Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Try to unpin mpich after new version available. #5

Merged
merged 5 commits into from
Feb 2, 2021
Merged

FIX: Try to unpin mpich after new version available. #5

merged 5 commits into from
Feb 2, 2021

Conversation

hhslepicka
Copy link
Contributor

@hhslepicka hhslepicka commented Jan 29, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Trying to unpin after work done for conda-forge/mpich-feedstock#56

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hhslepicka
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@hhslepicka
Copy link
Contributor Author

Rebased to pick up the latest release info.

@leofang
Copy link
Member

leofang commented Feb 2, 2021

The mpich fix is in, let's give it a shot

@conda-forge-admin, please restart ci

@hhslepicka
Copy link
Contributor Author

@leofang it looks like it did it! Thanks for restarting CI here.

@leofang
Copy link
Member

leofang commented Feb 2, 2021

Cool! Perhaps you'd like to clean up the workarounds you added (fake-bin etc)?

@hhslepicka
Copy link
Contributor Author

I will try to remove the fake-bin one but it was related to osx issue with cc1 that was not found somehow.

@leofang
Copy link
Member

leofang commented Feb 2, 2021

Ah I see, I thought it was for fixing the OS X build. nvm then.

@hhslepicka hhslepicka merged commit 83b2136 into conda-forge:master Feb 2, 2021
@hhslepicka hhslepicka deleted the unpin_mpich branch February 2, 2021 19:09
@hhslepicka
Copy link
Contributor Author

@leofang for reference, the cc1 issue comes from here: conda-forge/gfortran_osx-64-feedstock#11 and the workaround from here https://github.com/awvwgk/staged-recipes/tree/dftd4/recipes/dftd4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants