Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build 1.5.5 #8

Merged
merged 5 commits into from
Oct 31, 2017
Merged

build 1.5.5 #8

merged 5 commits into from
Oct 31, 2017

Conversation

megies
Copy link
Contributor

@megies megies commented Jun 27, 2017

Didn't check if dependencies have changed.. they're not listed in setup.py and I didn't bother to look through the whole code base.

Also, since github is not providing SHA sums for release tarballs, that's what I got from a manually downloaded tarball.. which kind of mocks out the whole concept.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Looks like it needs a re-render as well.

@jakirkham
Copy link
Member

This is a bit old, but here is what I found in anaconda-recipes. Seems the requirements have been changed.

@megies
Copy link
Contributor Author

megies commented Jun 27, 2017

Ran into an error during re-rendering.. but it did something..

$ conda smithy rerender
No circle token.  Create a token at https://circleci.com/account/api and
put it in ~/.conda-smithy/circle.token
No appveyor token. Create a token at https://ci.appveyor.com/api-token and
Put one in ~/.conda-smithy/appveyor.token
No anaconda token. Create a token via
  anaconda auth --create --name conda-smithy --scopes "repos conda api"
and put it in ~/.conda-smithy/anaconda.token
Fetching package metadata .............
Traceback (most recent call last):
  File "/home/megies/anaconda/bin/conda-smithy", line 6, in <module>
    sys.exit(conda_smithy.cli.main())
  File "/home/megies/anaconda/lib/python2.7/site-packages/conda_smithy/cli.py", line 283, in main
    args.subcommand_func(args)
  File "/home/megies/anaconda/lib/python2.7/site-packages/conda_smithy/cli.py", line 188, in __call__
    configure_feedstock.main(args.feedstock_directory)
  File "/home/megies/anaconda/lib/python2.7/site-packages/conda_smithy/configure_feedstock.py", line 709, in main
    render_circle(env, config, forge_dir)
  File "/home/megies/anaconda/lib/python2.7/site-packages/conda_smithy/configure_feedstock.py", line 77, in render_circle
    forge_config.get('channels', {}).get('sources', tuple())
  File "/home/megies/anaconda/lib/python2.7/site-packages/conda_smithy/configure_feedstock.py", line 628, in compute_build_matrix
    mtx = special_case_version_matrix(meta, index)
  File "/home/megies/anaconda/lib/python2.7/site-packages/conda_build_all/version_matrix.py", line 223, in special_case_version_matrix
    py_vn = minor_vn(index[python_pkg.fn]['version'])
KeyError: u'python-3.3.0-pro0.tar.bz2'

@jakirkham
Copy link
Member

Have you upgraded conda-build-all?

@mbargull
Copy link
Member

Note that 1.6.0 is not a tag on the master branch but on another branch, associated with a pull request. 1.5.5 is the latest release from master.
(Also, I'd add pyyaml as a run requirement -- see the (declined) PR ContinuumIO/anaconda-recipes#104)

@jakirkham
Copy link
Member

I agree with your adjustments, @mbargull. Would you like to pick up this PR?

@megies
Copy link
Contributor Author

megies commented Jun 28, 2017

Have you upgraded conda-build-all?

Upgraded now (from 1.0.3 to 1.0.4), re-rendering now doesnt show an error (I did it again).

Stepped back to 1.5.5 and added pyyaml as dep.

@scopatz scopatz mentioned this pull request Oct 31, 2017
Closed
commands:
- constructor --help
- constructor --test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not --help?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess AnacondaRecipes does the same thing. Still curious as to why you made the switch, but it is non-blocking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess you can blame it on my general packaging paranoia. ;-)
But I feel that even though the release itself should be properly tested, why not run tests if possible during packaging as well? There's always something can go wrong during packaging, even if the release is looking good.

- pillow >=3.1 # [win]
- nsis # [win]
- nsis >=3.01 # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this means we need to update nsis.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating in PR ( conda-forge/nsis-feedstock#7 ).

@jakirkham jakirkham changed the title build 1.6.0 build 1.5.5 Oct 31, 2017
@jakirkham jakirkham merged commit 0661507 into conda-forge:master Oct 31, 2017
@jakirkham
Copy link
Member

Thanks @megies. Sorry for the long delay.

@megies megies deleted the build_1.6.0 branch November 1, 2017 10:13
jaimergp pushed a commit to jaimergp/constructor-feedstock that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants