-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build 1.5.5 #8
build 1.5.5 #8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like it needs a re-render as well. |
This is a bit old, but here is what I found in anaconda-recipes. Seems the requirements have been changed. |
Ran into an error during re-rendering.. but it did something..
|
Have you upgraded |
Note that |
I agree with your adjustments, @mbargull. Would you like to pick up this PR? |
Upgraded now (from 1.0.3 to 1.0.4), re-rendering now doesnt show an error (I did it again). Stepped back to 1.5.5 and added pyyaml as dep. |
commands: | ||
- constructor --help | ||
- constructor --test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not --help
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess AnacondaRecipes
does the same thing. Still curious as to why you made the switch, but it is non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I guess you can blame it on my general packaging paranoia. ;-)
But I feel that even though the release itself should be properly tested, why not run tests if possible during packaging as well? There's always something can go wrong during packaging, even if the release is looking good.
- pillow >=3.1 # [win] | ||
- nsis # [win] | ||
- nsis >=3.01 # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess this means we need to update nsis
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating in PR ( conda-forge/nsis-feedstock#7 ).
Thanks @megies. Sorry for the long delay. |
Update to 3.4.2
Didn't check if dependencies have changed.. they're not listed in setup.py and I didn't bother to look through the whole code base.
Also, since github is not providing SHA sums for release tarballs, that's what I got from a manually downloaded tarball.. which kind of mocks out the whole concept.