Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-store v2024.11.1 #47

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Nov 9, 2024

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11753705350 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.
  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@peytondmurray
Copy link

@soapy1 I had to update the recipe because we now pin pyyaml==5.3.1. Can you double check this all looks okay?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@trallard
Copy link
Member

@conda-forge-admin, please rerender

@jaimergp
Copy link
Member

jaimergp commented Nov 11, 2024

The TypeAlias error is a Python 3.13 I think? I also added CFEP-25-compliant Python deps.

Edit: No, TypeAlias is Python 3.10+. We should patch that.

@peytondmurray
Copy link

Blocked until conda-incubator/conda-store#973 gets merged.

@peytondmurray
Copy link

peytondmurray commented Nov 12, 2024

@jaimergp What's the motivation for pinning python 3.8 here? Was your note about CFEP-25 referring to this part?

However, we strongly recommend that maintainers always test their package against the oldest Python version for which it would install in order to ensure compatibility.

I guess with this in place we cannot install in environments containing python>3.8?

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

@conda-forge-admin, please rerender

@soapy1
Copy link
Contributor

soapy1 commented Nov 12, 2024

Closing in favour of pushing a new release that is compatible with python 3.10+

@soapy1 soapy1 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants