Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin to hdf5 1.8.18 #394

Merged
merged 1 commit into from
Jun 2, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/pin_the_slow_way.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
'glib': 'glib 2.51.*', # 2.50.2
'gmp': 'gmp >=5.0.1,<7', # 6.1.0
'harfbuzz': 'harfbuzz 1.3.*', # 0.9.39
'hdf5': 'hdf5 1.8.17|1.8.17.*', # 1.8.17
'hdf5': 'hdf5 1.8.18|1.8.18.*', # 1.8.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjhelmus can you confirm if defaults version is still 1.8.17?

(It is probably safe for conda-forge to move to 1.8.18 b/c we do have all the packages that uses hdf5 packaged in conda-forge.)

Copy link
Contributor Author

@qwhelan qwhelan Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still 1.8.17 - I have a PR to update it here: ContinuumIO/anaconda-recipes#109

In my experience, my PRs get ignored even if it's about a remote code execution vuln.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwhelan are you referring to defaults or conda-forge? I am confused b/c you linked the PR to conda-forge, but that was merged and we are moving to the latest hdf5 thanks to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf Apologies, pasted the wrong link initially. I was referring to defaults

'icu': 'icu 58.*', # 54.1
'jpeg': 'jpeg 9*', # 9b (but defaults is probably using 8d)
'libblitz': 'libblitz 0.10|0.10.*', # NA
Expand Down