DOC: Note extra.feedstock-name must be text not Jinja2 variable #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* extra.feedstock must be text (e.g. fastjet-contrib) and not a Jinja2 variable
(e.g. {{ name }}) as the conda-forge-webservices bot will not recognize
and act on the variable.
- c.f. https://github.com/conda-forge/fastjet-contrib-feedstock PR 3
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
cc @isuruf and @jakirkham for review given they were engaged in the discussion on conda-forge/conda-forge-webservices#786 and the resolution in conda-forge/fastjet-contrib-feedstock#3. Relevant bit of preview for review: https://deploy-preview-2406--conda-forge-previews.netlify.app/docs/maintainer/knowledge_base/#common-pitfalls-with-outputs |
|
Ah, on phone so haven't properly checked yet, but I think conda-forge/conda-forge-webservices#803 fixes the issue so that my PR isn't needed. |
|
Yep, I think we can close here, thanks for bringing this to our attention though! |
matthewfeickert
deleted the
doc/note-feedstock-name-extra-must-be-text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra.feedstockmust be text (e.g.fastjet-contrib) and not a Jinja2 variable (e.g.{{ name }}) as the conda-forge-webservices bot will not recognize and act on the variable.PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfileThis is the PR I said I would make in Bot update team request not working reliably conda-forge-webservices#786 (comment).