Added Perl package in Knowledge base #1666

prachinandi · 2022-03-30T14:56:10Z

PR Checklist:

make all edits to the docs in the src directory, not in docs or in the html files
note any issues closed by this PR with closing keywords
put any other relevant information below
fixes Add Perl package hints to documentation #1536

prachinandi · 2022-03-30T14:59:47Z

@kathatherine @beckermr @zklaus can u please review the PR. This is not the final one lot many changes are yet to be done, just wanted to know if I am proceeding in the right direction and if I have been following exactly what is being asked to fix in issue #1536.

BastianZim · 2022-03-30T15:47:05Z

src/maintainer/knowledge_base.rst

+==================
+
+The most commonly used build system for perl packages is ``ExtUtils::MakeMaker``. 
+For the archetypical packaging of packages of this form, you can have a look at ``perl-file-which``'s recipe.


Super small comment: Maybe add a link to the package here?

Super small comment: Maybe add a link to the package here?

Sure sir! Will do that as well

@BastianZim from where can I get the package link?😅

https://github.com/conda-forge/perl-file-which-feedstock

All of conda-forge‘s feedstocks are listed at https://conda-forge.org/feedstock-outputs/

I would actually link to the meta.yaml directly:

https://github.com/conda-forge/perl-file-which-feedstock/blob/main/recipe/meta.yaml

zklaus · 2022-03-31T09:09:45Z

Great start! I think it would also be good to leave a pointer to this section in the getting started section.

I am a bit on the fence. Perhaps it's actually better not to include an example package here, but rather explain the full meta.yaml file. I think in any case, it would be good to add the bit about core, vendor, and site parts of Perl installations so maintainers can get an understanding of this even when not using MakeMaker.

Finally, the line under the section title should have the same length as the title itself.

jaimergp · 2022-03-31T09:17:25Z

src/maintainer/knowledge_base.rst

+
+The steps are as follows: 
+
+* The name is composed of ``perl-`` + the lowered version of the CPAN name.


Suggested change

* The name is composed of ``perl-`` + the lowered version of the CPAN name.

* The name is composed of ``perl-`` + the lower-cased version of the CPAN name.

jaimergp · 2022-03-31T09:18:00Z

src/maintainer/knowledge_base.rst

+The steps are as follows: 
+
+* The name is composed of ``perl-`` + the lowered version of the CPAN name.
+* The requirements contain ``make`` for build, ``perl`` and ``perl-extutils-makemaker`` for host, and perl for run.


Suggested change

* The requirements contain ``make`` for build, ``perl`` and ``perl-extutils-makemaker`` for host, and perl for run.

* The requirements contain ``make`` for ``build``, ``perl`` and ``perl-extutils-makemaker`` for ``host``, and ``perl`` for ``run``.

jaimergp · 2022-03-31T09:18:52Z

src/maintainer/knowledge_base.rst

+  build:
+  number: 0
+  noarch: generic
+  script:
+    - perl Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1
+    - make
+    - make test
+    - make install VERBINST=1


Suggested change

build:

number: 0

noarch: generic

script:

- perl Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1

- make

- make test

- make install VERBINST=1

build:

number: 0

noarch: generic

script:

- perl Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1

- make

- make test

- make install VERBINST=1

jaimergp · 2022-03-31T09:19:55Z

src/maintainer/knowledge_base.rst

+``Makefile.PL`` is the crucial one that guarantees installation into the vendor section, as well as non-interference with standard files by the ``NO_PERLLOCAL`` and ``NO_PACKLIST`` switches.
+
+.. note::
+ ``noarch: generic`` should be present only if the package is a pure perl one, i.e. contains no compiled c code or extensions, and that of course more requirements can be necessary.


Suggested change

``noarch: generic`` should be present only if the package is a pure perl one, i.e. contains no compiled c code or extensions, and that of course more requirements can be necessary.

``noarch: generic`` should be present only if the package is a pure perl one (i.e. contains no compiled C code or extensions), and that of course more requirements can be necessary.

and that of course more requirements can be necessary

What do you mean here exactly?

jaimergp · 2022-03-31T09:22:54Z

src/maintainer/knowledge_base.rst

+
+* The name is composed of ``perl-`` + the lowered version of the CPAN name.
+* The requirements contain ``make`` for build, ``perl`` and ``perl-extutils-makemaker`` for host, and perl for run.
+* The tests section under imports lists the CPAN module that can be ``used`` in perl.


Suggested change

* The tests section under imports lists the CPAN module that can be ``used`` in perl.

* The tests section under ``imports`` lists the CPAN module that can be ``used`` in perl.

patch-2

4785c6d

prachinandi requested a review from a team as a code owner March 30, 2022 14:56

BastianZim reviewed Mar 30, 2022

View reviewed changes

jaimergp reviewed Mar 31, 2022

View reviewed changes

prachinandi added 6 commits April 2, 2022 21:31

Update knowledge_base.rst

7984ff8

Update knowledge_base.rst

0d52526

Update knowledge_base.rst

a1895a7

Update knowledge_base.rst

9821a91

Update knowledge_base.rst

87ac2cd

patch3

c070d30

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Perl package in Knowledge base #1666

Added Perl package in Knowledge base #1666

prachinandi commented Mar 30, 2022 •

edited

Loading

prachinandi commented Mar 30, 2022

BastianZim Mar 30, 2022

prachinandi Mar 30, 2022

prachinandi Mar 30, 2022

BastianZim Mar 30, 2022

jaimergp Mar 31, 2022

zklaus commented Mar 31, 2022

jaimergp Mar 31, 2022

jaimergp Mar 31, 2022 •

edited

Loading

jaimergp Mar 31, 2022

jaimergp Mar 31, 2022 •

edited

Loading

jaimergp Mar 31, 2022


		The steps are as follows:

		* The name is composed of ``perl-`` + the lowered version of the CPAN name.

	* The requirements contain ``make`` for build, ``perl`` and ``perl-extutils-makemaker`` for host, and perl for run.
	* The requirements contain ``make`` for ``build``, ``perl`` and ``perl-extutils-makemaker`` for ``host``, and ``perl`` for ``run``.

	``noarch: generic`` should be present only if the package is a pure perl one, i.e. contains no compiled c code or extensions, and that of course more requirements can be necessary.
	``noarch: generic`` should be present only if the package is a pure perl one (i.e. contains no compiled C code or extensions), and that of course more requirements can be necessary.

	* The tests section under imports lists the CPAN module that can be ``used`` in perl.
	* The tests section under ``imports`` lists the CPAN module that can be ``used`` in perl.

Added Perl package in Knowledge base #1666

Added Perl package in Knowledge base #1666

Conversation

prachinandi commented Mar 30, 2022 • edited Loading

prachinandi commented Mar 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zklaus commented Mar 31, 2022

Choose a reason for hiding this comment

jaimergp Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaimergp Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prachinandi commented Mar 30, 2022 •

edited

Loading

jaimergp Mar 31, 2022 •

edited

Loading

jaimergp Mar 31, 2022 •

edited

Loading