Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include GHA run link in more bot messages #781

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix: include GHA run link in more bot messages #781

merged 4 commits into from
Nov 21, 2024

Conversation

beckermr
Copy link
Member

Description

This PR includes the GHA run link in more messages. cc @jakirkham

@beckermr beckermr marked this pull request as ready for review November 21, 2024 10:27
@beckermr beckermr enabled auto-merge November 21, 2024 10:27
@beckermr beckermr requested a review from Copilot November 21, 2024 10:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

conda_forge_webservices/github_actions_integration/main.py:460

  • The term 'GitHub actions' should be consistently capitalized as 'GitHub Actions'.
f"GitHub actions workflow run [{run_link}]({run_link}). "
@beckermr beckermr requested a review from Copilot November 21, 2024 10:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • conda_forge_webservices/github_actions_integration/main.py: Evaluated as low risk
Comments skipped due to low confidence (4)

conda_forge_webservices/tokens.py:109

  • The term 'github actions' should be capitalized as 'GitHub Actions'.
"running in github actions"

conda_forge_webservices/tokens.py:160

  • The term 'github actions' should be capitalized as 'GitHub Actions'.
"made GITHUB token and masking it for github actions"

conda_forge_webservices/tokens.py:353

  • The term 'github actions' should be capitalized as 'GitHub Actions'.
"running in github actions"

conda_forge_webservices/tokens.py:420

  • The term 'github actions' should be capitalized as 'GitHub Actions'.
"made GITHUB token and masking it for github actions"
@beckermr beckermr added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 1a6c8db Nov 21, 2024
96 of 98 checks passed
@beckermr beckermr deleted the gha-link branch November 21, 2024 16:35
@jakirkham
Copy link
Member

Thanks Matt! 🙏

This has been helpful 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants