Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot update team request not working reliably #786

Open
jakirkham opened this issue Nov 27, 2024 · 9 comments
Open

Bot update team request not working reliably #786

jakirkham opened this issue Nov 27, 2024 · 9 comments

Comments

@jakirkham
Copy link
Member

A few attempts to refresh the team on kfp-server-api with the bot request have failed

Note that updating the team seems to work elsewhere:

So the command seems to work ok. Just not on the kfp-server-api feedstock

Do we have any ideas why this may be happening?

@jakirkham
Copy link
Member Author

cc @beckermr

@beckermr
Copy link
Member

Make sure everyone has accepted an invite to the org. Otherwise, best to watch the logs on heroku as you issue the command to see what is happening on the backend.

@jakirkham
Copy link
Member Author

Everyone has already accepted

Would it make sense for the bot to include a log link or perhaps a comment about the error? Currently it provides no status update

@beckermr
Copy link
Member

There is no log link since it happens on the backend server. We'd need to add comments on the error to smithy to get them out into the message.

@jakirkham
Copy link
Member Author

Looks like we have a new occurrence of this issue: conda-forge/fastjet-contrib-feedstock#2

@jakirkham jakirkham changed the title Bot update team request not working on kfp-server-api Bot update team request not working reliably Dec 14, 2024
@isuruf
Copy link
Member

isuruf commented Dec 14, 2024

@matthewfeickert
Copy link
Member

matthewfeickert commented Dec 14, 2024

Bot chokes on the jinja in https://github.com/conda-forge/fastjet-contrib-feedstock/blob/main/recipe/meta.yaml#L131-L135

So does that have to be static text (fastjet-contrib)? If so I'll make a PR to the docs to make this clear. Or is this a bot bug that can be fixed?

@jakirkham
Copy link
Member Author

Thanks Isuru! 🙏

Where did you find that? Is there a log we should be looking at?

@matthewfeickert
Copy link
Member

Bot chokes on the jinja in https://github.com/conda-forge/fastjet-contrib-feedstock/blob/main/recipe/meta.yaml#L131-L135

This is now fixed in PR #803.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants