Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise an error when *.yml migration files are present #7036

Merged
merged 1 commit into from
Feb 15, 2025
Merged

raise an error when *.yml migration files are present #7036

merged 1 commit into from
Feb 15, 2025

Conversation

hobu
Copy link
Contributor

@hobu hobu commented Feb 14, 2025 •
edited by isuruf
Loading

As suggested in regro/cf-scripts#3704, raise an error when we encounter any *.yml files.

Fixes #7029

@hobu hobu requested a review from a team as a code owner February 14, 2025 23:28
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@isuruf isuruf merged commit 47b0a71 into conda-forge:main Feb 15, 2025
3 checks passed
@jakirkham
Copy link
Member

Thank you both! 🙏

Hopefully this helps people avoid this pitfall in the future

@hobu hobu deleted the trap-yml-migrations branch February 15, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on migration with .yml extension; should be .yaml
4 participants
@hobu @conda-forge-admin @jakirkham @isuruf