-
Notifications
You must be signed in to change notification settings - Fork 6
(Experimental) Port Envs to use conda-js #8
Conversation
}; | ||
|
||
return promise; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note on this file -- it's better to use bower to pull this in rather than copy in the code directly. This file is also named wrong as it's not minified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In bokeh
we stay away from bower
and we will happily drop npm
if time permits.
Changes:
|
Alright, so now this PR ports everything to |
As in |
But that makes sense only in the context of a shell, right? Though that's not really relevant here. |
Unless an environment can be made persistent (I doubt this), then yes, this will have to be removed. |
Any general comments on this version vs. master? |
I will review this later today. |
Here's an idea I had for how the 'Packages' list could be used. The user could check the boxes for all the packages they wanted to install/uninstall/update and then select the action at the bottom. This would make more sense with the single-page two-table layout @tswicegood was talking about, though, and if the buttons disabled themselves dynamically (e.g. you shouldn't be able to 'install' packages already installed or remove uninstalled packages). |
Does the column to the right indicate whether it is installed or not? Otherwise, it is confusing whether the checkboxes mean "select" or "install(ed)". |
It means "select". What I'm working on is putting "installed" and "all packages" in the same tab, and changing "all packages" to "available packages" so packages don't appear in both. |
Though, I think it makes more sense now to keep them on different tabs, and have "install" only show up on one tab and "update/uninstall" on the other. Oh well. |
Lots of UI changes here. This should be essentially feature-complete, |
This reverts commit 6407206.
- flask | ||
- conda | ||
- tornado | ||
- sockjs-tornado |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sockjs-tornado
has to be propagated to repo.continuum.io
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can help, but first I need a recipe. Can you add one to conda-recipes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've pushed the recipe up to conda-recipes.
@lidavidm, this looks really good. Huge improvement over the initial implementation. There was one issue, which prevented me from running this for a while, mainly checking for Note to anyone who would like to try this out: you need conda at |
@asmeurer, when this is merged, I think we should move the conda-ui to conda organization (?). |
@mattpap Thanks for reviewing this. If you or anyone has specific comments on the functionality I can fix those (and I'll get the |
Someone apparently already did this (?) |
Yes, @teoliphant went ahead and moved the repository. |
@mattpap Should we merge this and then keep working on it? |
@lidavidm, please merge. Sorry, I got sidetracked with other work. |
(Experimental) Port Envs to use conda-js
This is ready for review.
Changes:
conda-js
. Runs conda through a subprocessconda update --all --dry-run
instead)TODO:
Images: