Add order_by option with support for 'string' ordering #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add WIP String versioning add ExtractString test add note to README Signed-off-by: cscanlin <[email protected]>
cscanlin-kwh
force-pushed
the
string-version-option
branch
from
0c5a0a0
to
81fe566
Compare
cscanlin-kwh
commented
Apr 29, 2023
| return match, true | ||
| } | ||
|
|
||
| func Extract(path string, pattern string, order_by string) (Extraction, bool) { |
There was a problem hiding this comment.
Is this really the best way to do this kind of polymorphism in Go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes:
#122
Use case here is for any files which have a natural sorting, that is not semantic versioning.
In our case we want to timestamp each file using an isodate string, which gives us natural time based ordering (but this PR does not explicitly check file upload time)
I'm somewhat new to go, so please let me know if there are any ways to improve this implementation, thanks!