Skip to content

Commit

Permalink
Merge pull request #16 from concourse/image-args
Browse files Browse the repository at this point in the history
use image args for FROM, use golang-builder
  • Loading branch information
vito committed Jan 15, 2021
2 parents 75d0270 + 5aea10c commit 19e7ae3
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
7 changes: 5 additions & 2 deletions dockerfiles/alpine/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
FROM golang:1 as builder
ARG base_image=alpine:latest
ARG builder_image=concourse/golang-builder

FROM ${builder_image} as builder
WORKDIR /src

COPY go.mod .
Expand All @@ -12,7 +15,7 @@ RUN set -e; for pkg in $(go list ./...); do \
go test -o "/tests/$(basename $pkg).test" -c $pkg; \
done

FROM alpine:edge AS resource
FROM ${base_image} AS resource
RUN apk add --update \
bash \
curl \
Expand Down
23 changes: 12 additions & 11 deletions dockerfiles/ubuntu/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,33 +1,34 @@
FROM concourse/golang-builder as builder
WORKDIR /src
ARG base_image
ARG builder_image=concourse/golang-builder

FROM ${builder_image} as builder
WORKDIR /src
COPY go.mod .
COPY go.sum .
RUN go mod download

COPY . .
ENV CGO_ENABLED 0
RUN go build -o /assets/hgresource ./hgresource
RUN set -e; for pkg in $(go list ./...); do \
go test -o "/tests/$(basename $pkg).test" -c $pkg; \
done

FROM ubuntu:bionic AS resource
FROM ${base_image} AS resource
RUN apt-get update && apt-get install -y --no-install-recommends \
curl \
ca-certificates \
gnupg \
jq \
openssh-client \
python \
python-pip \
python3 \
python3-pip \
build-essential \
python-all-dev \
python-setuptools \
python-wheel \
python3-all-dev \
python3-setuptools \
python3-wheel \
&& rm -rf /var/lib/apt/lists/* \
&& pip2 install mercurial \
&& pip2 install hg-evolve
&& pip3 install mercurial \
&& pip3 install hg-evolve

COPY --from=builder /assets /opt/resource
RUN chmod +x /opt/resource/*
Expand Down

0 comments on commit 19e7ae3

Please sign in to comment.