Allow filtering version below a specified version #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2018 11:57
For the sake of consistency
|
Sorry, this PR has a bug with first time run. I will update the branch and comment to notify. |
This helps apply version filter before other conditions/filters
akshaymankar
pushed a commit
to cloudfoundry-incubator/kubo-ci
that referenced
this pull request
Feb 8, 2018
Using fork of the github-release-resource for now When they merge our changes, we can use the default concourse resource PR: concourse/github-release-resource#68 [#154928281] Signed-off-by: Tony Wong <[email protected]>
|
The bug is now fixed. Please let me know if anything else is required for this to be merged. |
|
@akshaymankar Thanks so much for taking the time to submit a PR for this (with tests)! However I'm kind of tempted to wait for concourse/concourse#1707 instead of merging this. Once concourse/concourse#1707 lands we can add support for spaces to this resource, and you could specify a space filter like |
|
Closing per the previous comment. Thanks again, and long live concourse/concourse#1707! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67