Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace some of lodash with native functions #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

live627
Copy link

@live627 live627 commented Sep 29, 2021

  • The recursive cloning methods were retained as their individual npm packages
  • I tried replacing lodash.merge with Object.assign but some tests failed; seems the two methods may handle undefined differently
  • Array.prototype.flat was introduced in NodeJS v11 so you'll need to drop v10 from the testing matrix
  • is hasLength even used? The only reference to it seems unused

The recursive cloning methods were retained as their individual npm packages
@novemberborn
Copy link
Member

Thanks for this @live627. My spare-time-open-source efforts are currently focused on AVA but I'll keep this open.

@live627
Copy link
Author

live627 commented Oct 4, 2021 via email

@XhmikosR
Copy link

XhmikosR commented Jan 20, 2022

@novemberborn friendly ping :)

Not sure if this PR is good or not, but I'd love to see lodash removed from this package, assuming it doesn't need a lot of new code :)

@tommy-mitchell tommy-mitchell mentioned this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants