Prepare build compatibles refactor #16919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
approved these changes
Sep 2, 2024
AbrilRBS
reviewed
Sep 2, 2024
| @@ -328,6 +328,7 @@ class ConanInfo: | |||
| def __init__(self, settings=None, options=None, reqs_info=None, build_requires_info=None, | |||
| python_requires=None, conf=None, config_version=None): | |||
| self.invalid = None | |||
| self.cant_build = False # It will set to a str with a reason if the validate_build() fails | |||
There was a problem hiding this comment.
Dont we want to serialize/clone this when calling the appropiate methods?
There was a problem hiding this comment.
This was already being serialized as some "root" information of the node, not as cpp_info field, I thought it is better to not break the serialization output, so it keeps being serialized above in result["invalid_build"] = getattr(getattr(self.conanfile, "info", None), "cant_build", False)
ErniGH
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
This should be a pure refactor.
In preparation for #16871
root_node.cant_build=>root_node.conanfile.info.cant_build, so thecant_buildinformation belongs perinfo, so multiple "compatible" packages can be analyzed if they can be built or not.def _process_compatible_packages(self, node, remotes, update):into_get_compatiblesand_compatible_found()so they can be reused