Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/forced cppstd #16456

Closed
wants to merge 6 commits into from
Closed

Feature/forced cppstd #16456

wants to merge 6 commits into from

Conversation

memsharded
Copy link
Member

Changelog: Feature: Allow access to cppstd helpers like valid_min_cppstd inside package_id().
Docs: https://github.com/conan-io/docs/pull/XXXX

Close #16147

@memsharded memsharded added this to the 2.5.0 milestone Jun 10, 2024
@memsharded memsharded marked this pull request as ready for review June 13, 2024 12:09
@memsharded memsharded requested a review from AbrilRBS June 13, 2024 12:09
@memsharded
Copy link
Member Author

I am moving this forward because the Settings class got some protection against writing, which was the major concern if the package_id() method accidentally changed self.settings instead of changing self.info.settings. As this cannot happen now, this should be quite low risk.

@memsharded memsharded mentioned this pull request Jun 19, 2024
Closed
1 task
@memsharded memsharded marked this pull request as draft June 21, 2024 10:39
@memsharded memsharded modified the milestones: 2.5.0, 2.6.0 Jul 1, 2024
@memsharded memsharded modified the milestones: 2.6.0, 2.7.0 Jul 29, 2024
@memsharded
Copy link
Member Author

Waiting for investigation to see if it is possible to build a fallback cppstd compatible configuration instead of failing if the current profile is not a valid one.

@memsharded memsharded modified the milestones: 2.7.0, 2.8.0 Aug 25, 2024
@memsharded
Copy link
Member Author

Closing as deprecated/superseded by #16871

@memsharded memsharded closed this Sep 24, 2024
@memsharded memsharded deleted the feature/forced_cppstd branch September 24, 2024 13:23
@memsharded memsharded removed this from the 2.8.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jcar87 jcar87 jcar87 approved these changes

Assignees

@jcar87 jcar87

Labels
type: feature type: look into
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[question] ability to call cppstd helpers in conan.tools.build within a package_id() method
3 participants
@memsharded @jcar87 @AbrilRBS