openvr: add 1.16.8 + fix cpp_info.includedirs + propagate libcxx for C API #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SSE4
previously approved these changes
Apr 11, 2021
prince-chrismc
previously approved these changes
Apr 12, 2021
|
FYI, a new version of openvr is available, but it doesn't compile without these fixes: ValveSoftware/openvr#1524, and PR author still see several issues, so I don't want to waste time with this new version. |
SpaceIm
changed the title
This was referenced Apr 12, 2021
This comment has been minimized.
This comment has been minimized.
prince-chrismc
approved these changes
Apr 13, 2021
SSE4
approved these changes
Apr 13, 2021
uilianries
approved these changes
Apr 13, 2021
|
jsoncpp is vendored in openvr, I'll see if it can be extracted. |
AlvaroFS
pushed a commit
to AlvaroFS/conan-center-index
that referenced
this pull request
May 7, 2021
…gate libcxx for C API * delete fPIC if shared in configure() * explicit pkg_config name * fix cpp_info.includedirs * consistent quotes * propagate libcxx if static for C API * dl system libs on Linux and FreeBSD only * add Foundation framework for all Apple OS * add 1.16.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
cpp_info.includedirswas wrong: https://github.com/ValveSoftware/openvr/blob/4c85abcb7f7f1f02adaf3812018c99fc593bc341/src/openvr.pc.in#L4I've kept the previous one to not break consumers.
conan-center hook activated.