libcap/2.73: Bump version #26246
Merged
libcap/2.73: Bump version #26246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErniGH
reviewed
Dec 30, 2024
|
|
||
| # Always build libcap sources this way: | ||
| -CFLAGS += -fPIC -D_LIBPSX_PTHREAD_LINKAGE | ||
| +CFLAGS += -D_LIBPSX_PTHREAD_LINKAGE |
There was a problem hiding this comment.
Hi @bobrofon, Why is this line added if nothing similar was added in the previous patch? I couldn’t find anything
upstream—could you help me? 😄
There was a problem hiding this comment.
In the previous patch, the -fPIC flag was removed from CFLAGS. In this patch, the -fPIC flag is also removed from CFLAGS. Honestly, I don't see any difference.
-CFLAGS += -fPICvs
-CFLAGS += -fPIC -D_LIBPSX_PTHREAD_LINKAGE
+CFLAGS += -D_LIBPSX_PTHREAD_LINKAGEThere was a problem hiding this comment.
The associated change in the upstream: https://git.kernel.org/pub/scm/libs/libcap/libcap.git/diff/libcap/Makefile?id=libcap-2.73&id2=libcap-2.70
-CFLAGS += -fPIC
+CFLAGS += -fPIC -D_LIBPSX_PTHREAD_LINKAGE
jcar87
approved these changes
Dec 30, 2024
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libcap/2.73
Motivation
A new version of libcap is available. Full diff between 2.70 and 2.73: https://git.kernel.org/pub/scm/libs/libcap/libcap.git/diff/?id=libcap-2.73&id2=libcap-2.70
Details
Conan-specific patches are the same as for the previous versions. They are only rebased on version 2.73.