libvault: add 0.59.0 #21340

abedra · 2023-11-23T19:36:39Z

Specify library name and version: libvault/0.59.0

Adding version 0.59.0. It looks like this package was created by someone else but the versions haven't been maintained. I'll try to make sure these are updated as I create new releases.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-11-23T19:36:46Z

All committers have signed the CLA.

ghost · 2023-11-23T19:50:42Z

I detected other pull requests that are modifying libvault/all recipe:

libvault: fix import of Version + decrease min Visual Studio Version + many small fixes #19488

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

uilianries

Thank you for your first contribution! This PR should be built in few hours after #21399 being merged.

Signed-off-by: Uilian Ries <[email protected]>

uilianries

LGTM

Signed-off-by: Uilian Ries <[email protected]>

conan-center-bot · 2024-04-22T07:57:10Z

Conan v1 pipeline ✔️

All green in build 5 (57d41cbfa7dc6ad3b5fd6bac4d066836776ccca9):

libvault/0.59.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (57d41cbfa7dc6ad3b5fd6bac4d066836776ccca9):

libvault/0.59.0:
All packages built successfully! (All logs)

uilianries

LGTM

AbrilRBS

Thanks a lot! Looks great now, I oinly have a minor question :)

AbrilRBS · 2024-04-23T08:28:39Z

recipes/libvault/all/conanfile.py

@@ -49,29 +61,18 @@ def layout(self):

    def requirements(self):
        # public header VaultClient.h includes curl/curl.h and use several functions
-        self.requires("libcurl/[>=7.78.0 <9]", transitive_headers=True, transitive_libs=True)
+        self.requires("libcurl/[>=7.78.0 <9]", transitive_headers=True)


Just a minor question, could you give me a bit more insight into why this was removed? Wy is it not needed?

I think it's because of this abedra/libvault#27 So, there is no need to make it visible downstream anymore.

* libvault: add 0.59.0 * Fix scm version import Signed-off-by: Uilian Ries <[email protected]> * Fix libvault patches Signed-off-by: Uilian Ries <[email protected]> * match the upstream master Signed-off-by: Uilian Ries <[email protected]> * apply patch on the fly Signed-off-by: Uilian Ries <[email protected]> * Add hotfix link Signed-off-by: Uilian Ries <[email protected]> * Drop version 0.48 Signed-off-by: Uilian Ries <[email protected]> * Drop old versions due Windows linkage error Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Uilian Ries <[email protected]>

abedra added 2 commits November 23, 2023 13:33

libvault: add 0.59.0

722f07b

Merge branch 'conan-io:master' into master

63397af

conan-center-bot added the User-approval pending label Nov 23, 2023

This comment has been minimized.

Sign in to view

abedra mentioned this pull request Nov 23, 2023

[!!] Access request #4

Closed

ghost mentioned this pull request Nov 23, 2023

[service] Potentially conflicting recipes #3571

Closed

prince-chrismc mentioned this pull request Nov 23, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Nov 24, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

ericLemanissier mentioned this pull request Nov 24, 2023

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

ghost mentioned this pull request Nov 24, 2023

libvault: fix import of Version + decrease min Visual Studio Version + many small fixes #19488

Merged

3 tasks

uilianries mentioned this pull request Nov 27, 2023

[bot] Update authorized users list (2023-11-27) #21399

Merged

uilianries previously approved these changes Nov 27, 2023

View reviewed changes

jwillikers approved these changes Nov 27, 2023

View reviewed changes

conan-center-bot added the Failed label Nov 30, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the User-approval pending label Dec 4, 2023

This comment has been minimized.

Sign in to view

Fix scm version import

ba5cb69

Signed-off-by: Uilian Ries <[email protected]>

uilianries dismissed their stale review via ba5cb69 December 5, 2023 09:18

uilianries previously approved these changes Dec 5, 2023

View reviewed changes

uilianries self-assigned this Dec 5, 2023

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Dec 27, 2023

fixed libvault recipe for 2.0 #21962

Closed

valgur approved these changes Feb 28, 2024

View reviewed changes

Fix libvault patches

8cc2a62

Signed-off-by: Uilian Ries <[email protected]>

uilianries dismissed their stale review via 8cc2a62 April 19, 2024 12:11

Merge branch 'master' into master

4c56ecf

match the upstream master

0f147da

Signed-off-by: Uilian Ries <[email protected]>

This comment has been minimized.

Sign in to view

uilianries added 2 commits April 19, 2024 15:36

apply patch on the fly

08701ca

Signed-off-by: Uilian Ries <[email protected]>

Add hotfix link

6232ee3

Signed-off-by: Uilian Ries <[email protected]>

This comment has been minimized.

Sign in to view

Drop version 0.48

21e018f

Signed-off-by: Uilian Ries <[email protected]>

This comment has been minimized.

Sign in to view

Drop old versions due Windows linkage error

57d41cb

Signed-off-by: Uilian Ries <[email protected]>

conan-center-bot removed the Failed label Apr 22, 2024

uilianries approved these changes Apr 22, 2024

View reviewed changes

uilianries requested a review from jwillikers April 22, 2024 08:29

AbrilRBS reviewed Apr 23, 2024

View reviewed changes

franramirez688 approved these changes Apr 23, 2024

View reviewed changes

conan-center-bot merged commit 8b04335 into conan-io:master Apr 23, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libvault: add 0.59.0 #21340

libvault: add 0.59.0 #21340

abedra commented Nov 23, 2023 •

edited

Loading

CLAassistant commented Nov 23, 2023 •

edited

Loading

This comment has been minimized.

ghost commented Nov 23, 2023

uilianries left a comment

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Apr 22, 2024

uilianries left a comment

AbrilRBS left a comment

AbrilRBS Apr 23, 2024

franramirez688 Apr 23, 2024

libvault: add 0.59.0 #21340

libvault: add 0.59.0 #21340

Conversation

abedra commented Nov 23, 2023 • edited Loading

Adding version 0.59.0. It looks like this package was created by someone else but the versions haven't been maintained. I'll try to make sure these are updated as I create new releases.

CLAassistant commented Nov 23, 2023 • edited Loading

This comment has been minimized.

ghost commented Nov 23, 2023

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Apr 22, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

uilianries left a comment

Choose a reason for hiding this comment

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Apr 23, 2024

Choose a reason for hiding this comment

franramirez688 Apr 23, 2024

Choose a reason for hiding this comment

abedra commented Nov 23, 2023 •

edited

Loading

CLAassistant commented Nov 23, 2023 •

edited

Loading