-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrade: migrate to Conan v2 #18855
corrade: migrate to Conan v2 #18855
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done a couple of things to try to help and make this pass CI:
- Fixed VS2022 based on Update compiler workarounds for MSVC 2022 mosra/corrade#124 (compatibility for 2019 should be good to fix 2022)
- Removed the extra
tool_requires
intest_package
to simplify it. I know it is not fully testing the execution of the executable, but I think it is a good trade-off at this moment
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f53d6d7corrade/2020.06
corrade/2019.10
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
45e6910
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4ccc9ab
to
dd6f1fa
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ✔️
All green in build 11 ( |
tc = CMakeDeps(self) | ||
tc.generate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't hurt but it's useless since there is no requirements
from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rmdir | ||
from conan.tools.microsoft import is_msvc, check_min_vs | ||
|
||
required_conan_version = ">=1.52.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Features used in this recipe require at least conan 1.53.0 (self.options.rm_safe("fPIC")
for example).
* corrade: migrate to Conan v2 * disable VS2022, simplify test_package * allow vs2022 * corrade: fix conandata.yml patch attributes * corrade: auto-load all exported CMake module files * corrade: get rid of vs_ide_version() * Fix linter error --------- Co-authored-by: memsharded <[email protected]> Co-authored-by: Rubén Rincón Blanco <[email protected]>
No description provided.