Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve conan generator choice #433

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

pgrohs
Copy link

@pgrohs pgrohs commented Jun 13, 2022

in case the cmake_find_package generator is present in the recipe, the script should enable also the cmake_find_package_multi generator in case of multi-config projects

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@czoido
Copy link
Contributor

czoido commented Oct 26, 2022

Hi @pgrohs,
Sorry for the late review, and thanks for the contribution. I'm afraid this this is modifying part of the conan_cmake_run implementation that we don't recommend any more, please check the recommended way of using cmake-conan using conan_cmake_install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants