update broken tests

comsave · Feb 18, 2020 · f8fdd24 · f8fdd24
1 parent 9ddcb5d
commit f8fdd24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Comsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandler.php b/src/Comsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandler.php
@@ -132,7 +132,9 @@ public function process($sObject)
         }
 
         $allowedProperties = $this->getAllowedProperties($this->documentClassName);
-        $this->documentUpdater->updateWithDocument($mappedDocument, $existingDocument, null, $allowedProperties);
+        if(count($allowedProperties) > 0) {
+            $this->documentUpdater->updateWithDocument($mappedDocument, $existingDocument, null, $allowedProperties);
+        }
 
         $beforeFlushEvent = $this->outboundMessageBeforeFlushEventBuilder->build($mappedDocument, $existingDocument);
         $this->eventDispatcher->dispatch(OutboundMessageBeforeFlushEvent::NAME, $beforeFlushEvent);

diff --git a/...omsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandlerTest.php b/...omsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandlerTest.php
@@ -135,7 +135,7 @@ public function testNotificationsSuccessfulOnExistingDocument()
             ->willReturn($unitOfWorkMock);
 
         $mappedDocumentMock = $this->createMock(Product::class);
-        $mappedDocumentMock->expects($this->atLeastOnce())
+        $mappedDocumentMock->expects($this->once())
             ->method('getId')
             ->willReturn('897D6FGSD');
 
@@ -193,7 +193,7 @@ public function testNotificationsSuccessfulOnNewDocument()
             ->willReturn($unitOfWorkMock);
 
         $mappedDocumentMock = $this->createMock(Product::class);
-        $mappedDocumentMock->expects($this->atLeastOnce())
+        $mappedDocumentMock->expects($this->once())
             ->method('getId')
             ->willReturn('897D6FGSD');
 
@@ -251,7 +251,7 @@ public function testNotificationsSkipSuccessful()
             ->willReturn($unitOfWorkMock);
 
         $mappedDocumentMock = $this->createMock(Product::class);
-        $mappedDocumentMock->expects($this->atLeastOnce())
+        $mappedDocumentMock->expects($this->once())
             ->method('getId')
             ->willReturn('897D6FGSD');