FEMSSPRT-376: Fix Duplicate Contact Detection

[shahrukh-compuco]

Overview

This pr fixes the detection of duplicate contact. Prior to this pr if a dedupe rule used email field for detecting duplicates then it did not work if the duplicates were between the contacts other than the first contact as the email for first contact is saved at the time of validation but for other contacts the emails are saved at the end after all the contacts have been created and for this scenario two different contacts were getting created through webform submission even if they have same dedupe rule fields. This pr fixes the issue and now the duplicate contacts are detected successfully.

core pr: colemanw#1033

[jamienovick]

@shahrukh-compuco

"if a dedupe rule used email field for detecting duplicates then it did not work and two different contacts were getting created through webform submission"

1. When you say, "if a dedupe rule used email field for detecting duplicates", do you mean any rule which included using email, or only rules which are email only?
2. This sounds like it would be a big issue, do you know when it started? I'm sure this worked in the past...
3. Are we fixing this in the core module and sending PR? Just again, it seems so big/fundamental that I'm wondering how its not been found before!

[shahrukh-compuco]

@shahrukh-compuco

"if a dedupe rule used email field for detecting duplicates then it did not work and two different contacts were getting created through webform submission"

1. When you say, "if a dedupe rule used email field for detecting duplicates", do you mean any rule which included using email, or only rules which are email only?
2. This sounds like it would be a big issue, do you know when it started? I'm sure this worked in the past...
3. Are we fixing this in the core module and sending PR? Just again, it seems so big/fundamental that I'm wondering how its not been found before!

@jamienovick

1. I mean any rule that included email field
2. I checked to find out when it started but I dont see any such commit that could introduce this issue, but there is one thing worth mentioning that it will work fine if the duplicate is between contact 1 and other contacts but if the duplicates does not involve contact 1 then it would be an issue as the email for first contact is created at the time of validation but for other contacts the emails are saved at the end after all the contacts have been created already.
3. Will check on this with the team as I am not sure that we are sending the prs to this core module or not

[jamienovick]

Could you update the description to make 2 clear?

[shahrukh-compuco]

Could you update the description to make 2 clear?

done