Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-queue check for cancelTransaction() in Timelock.sol #213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AmazingAng
Copy link

@AmazingAng AmazingAng commented Aug 12, 2022

Add in-queue check for cancelTransaction() in Timelock.sol :

        require(queuedTransactions[txHash], "Timelock::cancelTransaction: Transaction hasn't been queued.");

before deleting the transaction from the queue:

        queuedTransactions[txHash] = false;

Link to #214

@AmazingAng
Copy link
Author

  1. Delete import SafeMath, since SafeMath is no longer needed starting with Solidity 0.8.
  2. Delete keyword "public" in constructor

@Setland34
Copy link

Add in-queue check for cancelTransaction() in Timelock.sol :

        require(queuedTransactions[txHash], "Timelock::cancelTransaction: Transaction hasn't been queued.");

before deleting the transaction from the queue:

        queuedTransactions[txHash] = false;

Link to #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants