Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wUSDM as collateral to USDT market on Mainnet #930

Merged
merged 13 commits into from
Nov 15, 2024
Merged

Add wUSDM as collateral to USDT market on Mainnet #930

merged 13 commits into from
Nov 15, 2024
+570 −2

Conversation

MishaShWoof
Copy link
Contributor

No description provided.

torreyatcitty
torreyatcitty approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@torreyatcitty torreyatcitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 15, 2024
View reviewed changes
contracts/pricefeeds/PriceFeedWith4626Support.sol
Comment on lines +52 to +63
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
rateProvider = rateProvider_;
underlyingPriceFeed = underlyingPriceFeed_;
rateProviderDecimals = IERC4626(rateProvider_).decimals();
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals();
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals));
description = description_;

if (decimals_ > 18) revert BadDecimals();
decimals = decimals_;
priceFeedScale = int256(10 ** decimals);
}

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument description_.
contracts/pricefeeds/PriceFeedWith4626Support.sol
Comment on lines +52 to +63
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
rateProvider = rateProvider_;
underlyingPriceFeed = underlyingPriceFeed_;
rateProviderDecimals = IERC4626(rateProvider_).decimals();
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals();
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals));
description = description_;

if (decimals_ > 18) revert BadDecimals();
decimals = decimals_;
priceFeedScale = int256(10 ** decimals);
}

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument rateProvider_.
contracts/pricefeeds/PriceFeedWith4626Support.sol
Comment on lines +52 to +63
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
rateProvider = rateProvider_;
underlyingPriceFeed = underlyingPriceFeed_;
rateProviderDecimals = IERC4626(rateProvider_).decimals();
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals();
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals));
description = description_;

if (decimals_ > 18) revert BadDecimals();
decimals = decimals_;
priceFeedScale = int256(10 ** decimals);
}

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning

There're no sanity checks for the constructor argument underlyingPriceFeed_.
contracts/pricefeeds/PriceFeedWith4626Support.sol
Comment on lines +52 to +63
constructor(address rateProvider_, address underlyingPriceFeed_, uint8 decimals_, string memory description_) {
rateProvider = rateProvider_;
underlyingPriceFeed = underlyingPriceFeed_;
rateProviderDecimals = IERC4626(rateProvider_).decimals();
underlyingDecimals = AggregatorV3Interface(underlyingPriceFeed_).decimals();
combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals));
description = description_;

if (decimals_ > 18) revert BadDecimals();
decimals = decimals_;
priceFeedScale = int256(10 ** decimals);
}

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.
@torreyatcitty torreyatcitty merged commit 9ee48e5 into compound-finance:main Nov 15, 2024
3 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitalii-woof-software vitalii-woof-software vitalii-woof-software left review comments

@torreyatcitty torreyatcitty torreyatcitty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MishaShWoof @torreyatcitty @vitalii-woof-software