Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Base Sepolia hardhat config; dont write enacted if simulating #837

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix Base Sepolia hardhat config; dont write enacted if simulating #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7258262
Fix Base Sepolia hardhat config; dont write enacted if simulating
kevincheng96 Mar 22, 2024
382feda
Use different RPC for base-sepolia
kevincheng96 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions deployments/base-sepolia/usdc/migrations/1710879470_configure_and_ens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,6 @@ export default migration('1710879470_configure_and_ens', {
trace(`Created proposal ${proposalId}.`);
},

async enacted(deploymentManager: DeploymentManager): Promise<boolean> {
return true;
},

async verify(deploymentManager: DeploymentManager, govDeploymentManager: DeploymentManager, preMigrationBlockNumber: number) {
const ethers = deploymentManager.hre.ethers;
await deploymentManager.spider(); // We spider here to pull in Optimism COMP now that reward config has been set
Expand Down
4 changes: 2 additions & 2 deletions hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ const networkConfigs: NetworkConfig[] = [
{
network: 'base-sepolia',
chainId: 84532,
url: `https://sepolia.base.org/`,
url: `https://clean-spring-wind.base-sepolia.discover.quiknode.pro/${QUICKNODE_KEY}`,
},
{
network: 'linea-goerli',
Expand Down Expand Up @@ -464,7 +464,7 @@ const config: HardhatUserConfig = {
name: 'base-sepolia-usdc',
network: 'base-sepolia',
deployment: 'usdc',
auxiliaryBase: 'sepolia'
auxiliaryBase: 'sepolia-usdc'
},
{
name: 'linea-goerli',
Expand Down
4 changes: 2 additions & 2 deletions tasks/deployment_manager/task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ task('migrate', 'Runs migration')
let governanceDm: DeploymentManager;
const base = env.config.scenario.bases.find(b => b.network === network && b.deployment === deployment);
const isBridgedDeployment = base.auxiliaryBase !== undefined;
const governanceBase = isBridgedDeployment ? env.config.scenario.bases.find(b => b.network === base.auxiliaryBase) : undefined;
const governanceBase = isBridgedDeployment ? env.config.scenario.bases.find(b => b.name === base.auxiliaryBase) : undefined;

if (governanceBase) {
const governanceEnv = hreForBase(governanceBase, simulate);
Expand Down Expand Up @@ -226,7 +226,7 @@ task('migrate', 'Runs migration')

await runMigration(dm, governanceDm, prepare, enact, migration, overwrite);

if (enact && !noEnacted) {
if (enact && !noEnacted && !simulate) {
await writeEnacted(migration, dm, true);
}
}
Expand Down
Loading