Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing scenarios #771

Merged
merged 9 commits into from
Jun 29, 2023
Merged

Fix failing scenarios #771

merged 9 commits into from
Jun 29, 2023

Conversation

scott-silver
Copy link
Contributor

@scott-silver scott-silver commented Jun 27, 2023

Attempting to fix as many of the currently-failing scenarios as possible.

The only errors that should remain after this PR are the Base deployments' inability to source cbETH.

@scott-silver scott-silver force-pushed the silver/fix-scenarios branch 2 times, most recently from 3c5af2e to a81e4c6 Compare June 27, 2023 22:49
@scott-silver scott-silver marked this pull request as ready for review June 27, 2023 22:50
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes 🔥

scenario/constraints/ReservesConstraint.ts Outdated Show resolved Hide resolved
scenario/constraints/ReservesConstraint.ts Outdated Show resolved Hide resolved
@kevincheng96
Copy link
Contributor

Did the liquidation scenarios just fix themselves?

@scott-silver
Copy link
Contributor Author

Did the liquidation scenarios just fix themselves?

It's been intermittent; added a new Arbitrum flash loan pool which should help

@scott-silver scott-silver merged commit 6d9c48c into main Jun 29, 2023
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants