Remove dead code and weak checks

composer · Nov 26, 2024 · 98a71d8 · 98a71d8
1 parent 359ac63
commit 98a71d8
Showing 1 changed file with 2 additions and 26 deletions.
diff --git a/src/Entity/PackageRepository.php b/src/Entity/PackageRepository.php
@@ -96,30 +96,6 @@ public function getProvidedNames(): array
         return array_map('strtolower', $names);
     }
 
-    /**
-     * @return array<string>
-     */
-    public function getPackageNamesByType(string $type): array
-    {
-        $query = $this->getEntityManager()
-            ->createQuery("SELECT p.name FROM App\Entity\Package p WHERE p.type = :type AND p.frozen IS NULL")
-            ->setParameters(['type' => $type]);
-
-        return $this->getPackageNamesForQuery($query);
-    }
-
-    /**
-     * @return array<string>
-     */
-    public function getPackageNamesByVendor(string $vendor): array
-    {
-        $query = $this->getEntityManager()
-            ->createQuery("SELECT p.name FROM App\Entity\Package p WHERE p.vendor = :vendor AND p.frozen IS NULL")
-            ->setParameters(['vendor' => $vendor]);
-
-        return $this->getPackageNamesForQuery($query);
-    }
-
     /**
      * @return array<string>
      */
@@ -128,11 +104,11 @@ public function getPackageNamesByTypeAndVendor(?string $type, ?string $vendor):
         $qb = $this->getEntityManager()->getRepository(Package::class)->createQueryBuilder('p')
             ->select('p.name')
             ->where('p.frozen IS NULL');
-        if ($type) {
+        if ($type !== null) {
             $qb->andWhere('p.type = :type')
                 ->setParameter('type', $type);
         }
-        if ($vendor) {
+        if ($vendor !== null) {
             $qb->andWhere('p.vendor = :vendor')
                 ->setParameter('vendor', $vendor);
         }