feat: Add bidirectional communication to exchange texts #108
Conversation
Signed-off-by: nidhal-labidi <[email protected]>
| }; | ||
|
|
||
| private configureDataChannel = () => { | ||
| if (this.dataChannel == null) { |
There was a problem hiding this comment.
| if (this.dataChannel == null) { | |
| if (this.dataChannel === null) { |
|
|
||
| private configureDataChannel = () => { | ||
| if (this.dataChannel == null) { | ||
| this.changeState('error', 'dataChannel is null. Unable to setup the configure it!'); |
There was a problem hiding this comment.
| this.changeState('error', 'dataChannel is null. Unable to setup the configure it!'); | |
| this.changeState('error', 'dataChannel is null. Unable to configure it!'); |
| if (this.dataChannel == null) { | ||
| this.changeState( | ||
| 'error', | ||
| 'dataChannel is null. Unable to setup the listeners for the data channel' | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Either === null or something like this:
| if (this.dataChannel == null) { | |
| this.changeState( | |
| 'error', | |
| 'dataChannel is null. Unable to setup the listeners for the data channel' | |
| ); | |
| return; | |
| } | |
| if (!this.dataChannel) { | |
| this.changeState( | |
| 'error', | |
| 'dataChannel is not defined. Unable to setup the listeners for the data channel' | |
| ); | |
| return; | |
| } |
| @@ -70,6 +71,11 @@ export class FlottformChannelHost extends EventEmitter<FlottformEventMap> { | |||
| this.openPeerConnection = new RTCPeerConnection(this.rtcConfiguration); | |||
|
|
|||
| this.dataChannel = this.createDataChannel(); | |||
| if (this.dataChannel) { | |||
| //this.dataChannel.bufferedAmountLowThreshold = this.BUFFER_THRESHOLD; | |||
There was a problem hiding this comment.
dead code
| //this.dataChannel.bufferedAmountLowThreshold = this.BUFFER_THRESHOLD; |
| @@ -5,7 +5,7 @@ | |||
| import { sdpExchangeServerBase } from '../../../api'; | |||
|
|
|||
| let currentState = $state< | |||
| 'init' | 'connected' | 'sending' | 'done' | 'error-user-denied' | 'error' | |||
| 'init' | 'connected' | 'text-transfered' | 'sending' | 'error-user-denied' | 'error' | |||
There was a problem hiding this comment.
typo
| 'init' | 'connected' | 'text-transfered' | 'sending' | 'error-user-denied' | 'error' | |
| 'init' | 'connected' | 'text-transferred' | 'sending' | 'error-user-denied' | 'error' |
There was a problem hiding this comment.
Shouldn't the host page have some change as well (looking for text-received event?)
There was a problem hiding this comment.
The file src/routes/flottform-text-client/[endpointId]/+page.svelte was created to test sending texts using Flottform. However, since we didn’t find a practical use case for sending texts at the time, we didn’t add a host file in the demo folder.
If you'd like, we can remove this file, as this PR contains a new messaging app in the demo that uses FlottformTextInputHost and FlottformTextInputClient. (demo/src/routes/flottform-messaging and demo/src/routes/flottform-messaging-client/[endpointId])
…om of the messages Signed-off-by: nidhal-labidi <[email protected]>
Checklist
Reviewer
Changes
Check the issue #107