feat: Add SecureTextField component and update TextField #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanlorng
force-pushed
the
text_field_password_type
branch
from
239aceb to
f1b8d56
Compare
This commit introduces the `SecureTextField` component, which is a text input field designed for securely entering private text like passwords. It also updates the `TextField` component with enhanced functionality.
Key changes:
- **SecureTextField**:
- Adds a new `SecureTextField` component that obscures the entered text.
- Provides options to customize text obfuscation using `textObfuscationMode` and `textObfuscationCharacter`.
- Includes `BasicSecureTextField` for the core text field functionality.
- Uses `KeyboardType.Password` by default.
- **TextField**:
+ **TextField Update**:
- Update the `TextField` component and add support `TextFieldState`, `header`, `placeholder`, `trailing`, `leadingIcon`, `clear`.
- Refactor `TextField` use new `TextFieldState`.
- **Sample**:
+ **Gallery Sample**:
- Adds a new sample screen that include `SecureTextField` and `TextField` in the Gallery app.
- Add Password guide in the README.md.
This commit refactors the TextField component by moving the header logic into the `DecorationBox`. Key changes: - The `HeaderContainer` composable is updated to use a custom `Layout` with a `HeaderMeasurePolicy` to correctly measure and position the header and content. - The `TextField` and `SecureTextField` composables now pass the `header` directly to the `DecorationBox`. - The `DecorationBox` in `TextFieldDefaults` is updated to accept and display the `header`. - A new `Container` composable is introduced within `TextFieldDefaults.DecorationBox` to encapsulate the visual styling of the TextField, including border and background. - The `modifier` parameter for drawing the bottom line is removed from `TextFieldDefaults.DecorationBox` as this is now handled by the new `Container`.
Sanlorng
force-pushed
the
text_field_password_type
branch
from
f1b8d56 to
2e28ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
SecureTextFieldcomponent, which is a text input field designed for securely entering private text like passwords. It also updates theTextFieldcomponent with enhanced functionality.close #103
close #114
Key changes:
SecureTextFieldcomponent that obscures the entered text.textObfuscationModeandtextObfuscationCharacter.BasicSecureTextFieldfor the core text field functionality.KeyboardType.Passwordby default.TextFieldcomponent and add supportTextFieldState,header,placeholder,trailing,leadingIcon,clear.TextFielduse newTextFieldState.HeaderContainercomposable is updated to use a customLayoutwith aHeaderMeasurePolicyto correctly measure and position the header and content.TextFieldandSecureTextFieldcomposables now pass theheaderdirectly to theDecorationBox.DecorationBoxinTextFieldDefaultsis updated to accept and display theheader.Containercomposable is introduced withinTextFieldDefaults.DecorationBoxto encapsulate the visual styling of the TextField, including border and background.modifierparameter for drawing the bottom line is removed fromTextFieldDefaults.DecorationBoxas this is now handled by the newContainer.SecureTextFieldandTextFieldin the Gallery app.