Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for scrolling within a scrollable container #13

Closed
wants to merge 1 commit into from
Closed

add support for scrolling within a scrollable container #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
components
build
66 changes: 66 additions & 0 deletions example-container.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
<html>
<head>
<title>scroll-to - smooth javascript window scrolling with requestAnimationFrame</title>
<style>
body {
padding: 50px;
overflow: hidden;
}

div {
position: relative;
overflow: auto;
width: 500px;
height: 300px;
}

ul {
min-width: 1500px;
overflow: hidden;
}

ul li {
margin: 10px;
padding: 5px;
list-style: none;
display: block;
float: left;
width: 100px;
height: 100px;
border: 1px solid #eee;
text-align: center;
line-height: 100px;
}
</style>
</head>
<body>
<div><ul></ul></div>

<script src="build/build.js"></script>

<script>
var scroll = require('scroll-to');
var events = require('event');
var ul = document.querySelector('ul');

for (var i = 0; i < 500; i++) {
var li = document.createElement('li');
li.textContent = 'item ' + i;
ul.appendChild(li);
}

var options = {
container: document.querySelector('div')
}

ul.addEventListener('click', function (e) {
var li = e.target
var x = li.offsetLeft
var y = li.offsetTop

console.log('scrolling to (%s, %s)', x, y);
scroll(x, y, options);
})
</script>
</body>
</html>
27 changes: 19 additions & 8 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,25 @@ function scrollTo(x, y, options) {
options = options || {};

// start position
var start = scroll();
var start = scroll(options);

// setup tween
var tween = Tween(start)
.ease(options.ease || 'out-circ')
.to({ top: y, left: x })
.duration(options.duration || 1000);

var updateScroll = options.container
? function (o) {
options.container.scrollTop = o.top | 0;
options.container.scrollLeft = o.left | 0;
}
: function (o) {
window.scrollTo(o.left | 0, o.top | 0);
}

// scroll
tween.update(function(o){
window.scrollTo(o.left | 0, o.top | 0);
});
tween.update(updateScroll);

// handle end
tween.on('end', function(){
Expand All @@ -48,7 +55,7 @@ function scrollTo(x, y, options) {
}

animate();

return tween;
}

Expand All @@ -59,8 +66,12 @@ function scrollTo(x, y, options) {
* @api private
*/

function scroll() {
var y = window.pageYOffset || document.documentElement.scrollTop;
var x = window.pageXOffset || document.documentElement.scrollLeft;
function scroll(options) {
var y = options.container
? options.container.scrollTop
: window.pageYOffset || document.documentElement.scrollTop;
var x = options.container
? options.container.scrollLeft
: window.pageXOffset || document.documentElement.scrollLeft;
return { top: y, left: x };
}