Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CPLYTM-421 create the validation component from the rules #414

Closed

Conversation

huiwangredhat
Copy link
Contributor

@huiwangredhat huiwangredhat commented Jan 14, 2025

Description

Create or update the validation component from the rules and parameters

Fixes # CPLYTM-421

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Tested locally and added one unit test case.

  1. Create the component itself with the type of service or software.
    poetry run trestlebot sync-cac-content --repo-path ~/trestle-repo --branch main --cac-content-root ~/content --cac-profile ~/content/products/rhel10/profiles/cis.profile --oscal-profile ~/content/controls/cis_rhel10.yml --committer-email [email protected] --committer-name huiwang --product rhel10 --dry-run --component-definition-type software
  2. Create a validation component for the component definition
    poetry run trestlebot sync-cac-content --repo-path ~/trestle-repo --branch main --cac-content-root ~/content --cac-profile ~/content/products/rhel10/profiles/cis.profile --oscal-profile ~/content/controls/cis_rhel10.yml --committer-email [email protected] --committer-name huiwang --product rhel10 --dry-run --component-definition-type validation

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@qduanmu
Copy link
Contributor

qduanmu commented Jan 14, 2025

Some codes from #411 in this PR have been deprecated, especially for codes in trestlebot/tasks/sync_cac_content_task.py, I would suggest you to checkout that commit and update based on it.

@huiwangredhat
Copy link
Contributor Author

Some codes from #411 in this PR have been deprecated, especially for codes in trestlebot/tasks/sync_cac_content_task.py, I would suggest you to checkout that commit and update based on it.
@qduanmu: I discussed that with you in the Slack channel. It's a good idea to push a commit to PR 411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants