-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Round 1 #175
Docs Round 1 #175
Conversation
Performance Ratio:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through the Intro and Algorithmic Differentiation pages, and took a peek at the Mathematical Interpretation of Functions one as well. Overall, this is very clearly written, and helped me a lot. I have essentially no previous experience of AD implementations and how they work.
I left a few comments. Related to the first comment, I think my largest confusion was with the infinitesimals/differentials \text{d} x
. The text also at a couple of points switched between that and \dot{x}
. They seem to be considered as elements of the same set as x
itself, which I found confusing given they are infinitesimal and more like tangents. I'm not sure what the best thing to do here is, but given that the later section about implementation seems to have to introduce the notion of tangent types anyway, I wonder if it would be useful to do so here in mathsland already. If not that, then a note about how the reader should think of \text{d} x
/\dot{x}
would be good.
Had a skim through it all and it looks very nice:) I don't really have any concrete feedback beyond what @mhauru has already given. I was also a bit confused by the switch between But all in all, I definitively think the docs achieve what it sets out to do! Many of the things you've mentioned to me about Tapir.jl before now makes more sense and I understand some of the design choices made much better:) |
#175 bumped some stuff in src, so there should have been a release made.
#175 bumped some stuff in src, so there should have been a release made.
This is the first round of documentation. The plan is to explain Tapir.jl's rule abstraction, and the tangent type system. The audience is intended to be those who are potentially interested in developin Tapir, rather than just using it.
This is not ready for review yet.
Note: if reading, be aware that I'm making extensive use of docstrings to create the documentation as this reduces the amount of duplication of documentation, and makes it easy to use doctests to avoid letting the documentation going out-of-sync with the code in future. Therefore, you should either use the docs preview, or build it locally, to get a proper sense of what the docs look like.
edit: todo
X^T X
explanation