Chore: devcontainer cleanups, update python version #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekaveman
force-pushed
the
chore/cleanup
branch
3 times, most recently
from
e3539ae
to
8650966
Compare
angela-tran
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
These changes look good to me!
Would it make sense to add multi-platform support to this template devcontainer? Like what was done in cal-itp/docker-python-web #36
easier to interact with Docker Compose this way
make python version a build arg
3.11 is the default
better support for engineers across Windows, Mac (incl Apple Silicon), and Linux
thekaveman
force-pushed
the
chore/cleanup
branch
from
bab5c16
to
6008fc1
Compare
Great suggestion / catch! This would have been annoying for @lalver1 and @machikoyasuda trying to use this devcontainer! Added in |
|
Looks good to me too! And thanks for the multi-platform support 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟢 I ran the workflow manually here: https://github.com/compilerla/template-devcontainer/actions/runs/9912876071
The newly tagged version images were built and pushed to GHCR:
main(now Python 3.11)main_3.10main_3.12