-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed inspect request using Preamble approach #21
Fixed inspect request using Preamble approach #21
Conversation
cc @ioanaif After talking to Johan, I got to know about the following i) The execute request and the inspect request are decoupled but then at the same time as we use So we have the following
|
Is there a way to add tests to this PR? cc: @JohanMabille |
Yes, we could instantiate an interpreter, call the |
@anutosh491, could you do that? |
5111e0c
to
72a3af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a test_interpreter.cpp
file instead of test_execute_request
, for:
- granularity, we don't want one file per tested feature
- naming:
test_execute_request
sounds like you test the whole path of an execute request sent from a client (including the middleware part)
b60b62f
to
f0d567f
Compare
…lementation requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We should add a subsequent PR tracking the testing coverage. We can take inspiration from https://github.com/compiler-research/CppInterOp/blob/d294b0790318522fd1eb0b0a2c786a4ba0347a58/.github/workflows/ci.yml#L46
2327afe
to
9722c68
Compare
On main
On branch