Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address todo related to variables provided by cppinterop #201

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

anutosh491
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Check compiler-research/CppInterOp#336 and #166

Variables coming out of cppinterop (CPPINTEROP_CONFIG, CPPINTEROP_DIR etc) were faulty leading to the following message

Found CppInterOp: config= dir= (found version= compatible with Clang 19.x)

Now that these have been fixed in 1.5.0, we have

Found CppInterOp: config=/Users/anutosh491/micromamba/envs/xeus-cpp/lib/cmake/CppInterOp dir=/Users/anutosh491/micromamba/envs/xeus-cpp (found version=1.5.0 compatible with Clang 19.x)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (e638f7c) to head (dba03cb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vgvassilev vgvassilev merged commit c2103eb into compiler-research:main Jan 6, 2025
12 checks passed
@anutosh491 anutosh491 deleted the fix_cmake branch January 6, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants