-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address resource dir config for kernels #172
base: main
Are you sure you want to change the base?
Address resource dir config for kernels #172
Conversation
Hmm weird, as can we seen through this commit (62980d0) using a new version of gcc (after updating cxx-compiler to 1.8.0 from 1.7.0) leads to few python tests failing. Let's debug this separately. |
62980d0
to
d6d31bc
Compare
My understanding here is this. For providing the resource dir
But as can be seen in DetectResourceDir we have this (https://github.com/compiler-research/CppInterOp/blob/826be787bb542fe2394a425de78613a4da3eae15/lib/Interpreter/CppInterOp.cpp#L2760) So as our resource dir is being provided out of clang (based from cxx-compiler) ... the latest that can be provided is version Hence the ways to approach this is
What has been done above is inclined towards the 2nd approach. I shall fix the tests in |
d6d31bc
to
fd0e463
Compare
Not ready yet. Bad attempt to be fair. Converting to draft |
Description
See https://discord.com/channels/1235591463472074924/1235591601523396680/1304415164753379441
Type of change
Please tick all options which are relevant.