Add notebook tests #142
Merged
Add notebook tests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage ? 82.72%
=======================================
Files ? 17
Lines ? 625
Branches ? 61
=======================================
Hits ? 517
Misses ? 108
Partials ? 0 |
vgvassilev
reviewed
Jun 8, 2024
vgvassilev
reviewed
Jun 10, 2024
vgvassilev
reviewed
Jun 10, 2024
vgvassilev
reviewed
Jun 11, 2024
vgvassilev
reviewed
Jun 11, 2024
vgvassilev
reviewed
Jun 11, 2024
|
Is this pull request still struggling to show a good user message if a notebook execution ends up with unexpected results or we are seeing something else? |
tharun571
force-pushed
the
main
branch
2 times, most recently
from
b213de3
to
33425e6
Compare
vgvassilev
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
This is simply awesome! LGTM!
@JohanMabille, could we move that feature up the jupyter stack?
|
Thanks @tharun571 for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using papermill library to execute the notebooks and check the necessary ouputs.
Tryng to fix #122
Type of change
Please tick all options which are relevant.