[WIP ] Fix failing Windows XCppTests #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 17 17
Lines 602 602
Branches 59 59
=======================================
Hits 452 452
Misses 150 150 |
|
https://github.com/compiler-research/xeus-cpp/actions/runs/9196698978/job/25295389281?pr=119 Proves that iostream is in one of the include folders that xcpp looks at. |
mcbarton
force-pushed
the
Fix-failing-Windows-tests
branch
from
d0f04bb
to
ccfeab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will attempt to fix the failing Windows XCppTests, so that Linux, osx and Windows are passing the same tests. The Windows version of the tests are currently separated out, with the intention of merging them once I have them passing.