Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource and include directories from kernel json #115

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 22, 2024

When creating the interpreter we already detect and add the arguments for the resource and include directories using CppInterOp here
https://github.com/mcbarton/xeus-cpp/blob/b58b15b83b27fe2e73c00c469346eea65301464d/src/xinterpreter.cpp#L37C1-L56C2 . This makes their addition in the kernel json file redundant.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (6692a45) to head (b58b15b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files          17       17           
  Lines         602      602           
  Branches       59       59           
=======================================
  Hits          422      422           
  Misses        180      180           

@mcbarton
Copy link
Collaborator Author

@anutosh491 @vgvassilev This PR is ready for review.

@vgvassilev
Copy link
Contributor

When creating the interpreter we already detect and add the arguments for the resource and include directories using CppInterOp here
https://github.com/mcbarton/xeus-cpp/blob/b58b15b83b27fe2e73c00c469346eea65301464d/src/xinterpreter.cpp#L37C1-L56C2

Unfortunately that works on some platforms depending if we have installed compiler and we can find the compiler...

The resource-dir is particularly tricky to find and in CppInterOp we need to figure out how to make it part of the library. Only then we can drop it and be confident that we are not shooting our feet...

@mcbarton
Copy link
Collaborator Author

When creating the interpreter we already detect and add the arguments for the resource and include directories using CppInterOp here
https://github.com/mcbarton/xeus-cpp/blob/b58b15b83b27fe2e73c00c469346eea65301464d/src/xinterpreter.cpp#L37C1-L56C2

Unfortunately that works on some platforms depending if we have installed compiler and we can find the compiler...

The resource-dir is particularly tricky to find and in CppInterOp we need to figure out how to make it part of the library. Only then we can drop it and be confident that we are not shooting our feet...

I'll convert this PR to a draft for now then, until that time comes where we are confident we can drop it.

@mcbarton mcbarton marked this pull request as draft May 22, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants