-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Add emscripten automated tests #483
base: main
Are you sure you want to change the base?
[wip] Add emscripten automated tests #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -18,7 +18,9 @@ | |||
#include "llvm/ADT/SmallString.h" | |||
#include "llvm/Support/Path.h" | |||
|
|||
#ifndef EMSCRIPTEN | |||
#include <gmock/gmock.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'gmock/gmock.h' file not found [clang-diagnostic-error]
#include <gmock/gmock.h>
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -18,15 +18,20 @@ | |||
#include "llvm/ADT/SmallString.h" | |||
#include "llvm/Support/Path.h" | |||
|
|||
#ifndef EMSCRIPTEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'gmock/gmock.h' file not found [clang-diagnostic-error]
#include <gmock/gmock.h>
^
Description
Please include a summary of changes, motivation and context for this PR.
My first PR to add automated emscripten tests became broken for unknown reasons (see #448). This PR is another attempt to added emscripten tests to CppInterOp
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist