Create a bespoke windows packager #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgodbolt
commented
Jun 24, 2024
| @@ -436,6 +436,7 @@ data "aws_iam_policy_document" "CeBuilderStorageAccess" { | |||
| actions = ["s3:*"] | |||
| resources = [ | |||
| "${aws_s3_bucket.compiler-explorer.arn}/opt/*", | |||
| "${aws_s3_bucket.compiler-explorer.arn}/opt-nonfree/*", | |||
There was a problem hiding this comment.
This was also needed, of course.
mattgodbolt
changed the title
|
We may wish to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@partouf any thoughts? I tested by running this as an
on: pullwith a hardcoded URL.One thing...if we do "latest" it will upload some unknowable files, e.g. I just ran it and got
14.41.33923-14.41.33923.0.zip- which then...we can't have a "latest" easily without somehow knowing the version number (and we'd end up with lots of S3 zipfiles).That said it's a start, and I think would work for non-latest OK. But I'd appreciate your faults. Part of #1331
Example of the resulting ZIPfile:
so I think it makes it right.