Fix ClientWorld memory leak in non-terrain light cache (fixes #209)

comp500 · Jul 10, 2023 · 8dbe4f9 · 8dbe4f9
1 parent 3b66ba1
commit 8dbe4f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/main/java/link/infra/indium/renderer/render/NonTerrainBlockRenderContext.java b/src/main/java/link/infra/indium/renderer/render/NonTerrainBlockRenderContext.java
@@ -61,6 +61,7 @@ public void render(BlockRenderView blockView, BakedModel model, BlockState state
 
 		// blockInfo is thread-local, not cleaned up when leaving world (and could be called for arbitrary BlockRenderViews)
 		blockInfo.release();
+		lightCache.release();
 		blockInfo.random = null;
 		this.vertexConsumer = null;
 	}

diff --git a/src/main/java/link/infra/indium/renderer/render/SingleBlockLightDataCache.java b/src/main/java/link/infra/indium/renderer/render/SingleBlockLightDataCache.java
@@ -53,4 +53,8 @@ public long get(int x, int y, int z) {
 
 		return this.light[l] = this.compute(x, y, z);
 	}
+
+	public void release() {
+		this.world = null;
+	}
 }