Feature/upgrade docusign library #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 785a547.
This reverts commit 49daa49.
This reverts commit 5da8906.
Signed-off-by: Umesh Lumbhani <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
nickmango
requested changes
Jul 21, 2023
.github/workflows/build-pr.yml
Outdated
| @@ -51,8 +51,9 @@ jobs: | |||
| - name: Python Setup | |||
| working-directory: cla-backend | |||
| run: | | |||
| pip install --platform manylinux2014_x86_64 --only-binary=:all: --target=/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages cryptography | |||
There was a problem hiding this comment.
create another requirements file such that theres backward compatability. You can create requirements-docusign.txt with the docusign-esign==3.22.0 package and then add the pip install command for this specific file ie pip install --platform manylinux2014_x86_64 --platform manylinux2014_x86_64 --only-binary=:all: --target=/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages cryptography -r requirements-docusign.txt
There was a problem hiding this comment.
@umeshlumbhani247 I have updated the code, please review the same,
Signed-off-by: Umesh Lumbhani <[email protected]>
nickmango
requested changes
Jul 21, 2023
cla-backend-go/Makefile
Outdated
| @@ -77,7 +77,7 @@ setup-dev: | |||
| echo "golangci-lint version:" && golangci-lint version | |||
|
|
|||
| @echo "==> Installing multi-file-swagger tool..." | |||
| cd $(dir $(realpath $(firstword $(MAKEFILE_LIST))))swagger && pip3 install virtualenv && virtualenv .venv && source .venv/bin/activate && python -m pip install --upgrade pip && pip3 install -r requirements.txt | |||
| cd $(dir $(realpath $(firstword $(MAKEFILE_LIST))))swagger && pip3 install virtualenv && virtualenv .venv && source .venv/bin/activate && python -m pip install --upgrade pip && pip3 install --platform manylinux2014_x86_64 --only-binary=:all: --target=/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages cryptography -r requirements-docusign.txt && pip3 install -r requirements.txt | |||
There was a problem hiding this comment.
Done @nickmango
Signed-off-by: Umesh Lumbhani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.