Skip to content

Commit

Permalink
[#3897]Feature/ICLA and ECLA use case
Browse files Browse the repository at this point in the history
- Changed flow for icla and ccla checks for an invalidated contributor use case

Signed-off-by: Harold Wanyama <[email protected]>
  • Loading branch information
nickmango committed Feb 6, 2024
1 parent 2adfda1 commit b48c470
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cla-backend/cla/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -698,10 +698,10 @@ def user_signed_project_signature(user: User, project: Project) -> bool:
# Verify if user has been approved: https://github.com/communitybridge/easycla/issues/332
cla.log.debug(f'{fn} - CCLA signature check - '
'checking to see if the user is in one of the approval lists...')
if project.get_project_ccla_requires_icla_signature() is True:
cla.log.debug(f'{fn} - CCLA signature check - '
'project requires ICLA signature as well as CCLA signature ')
elif user.is_approved(signature) :
# if project.get_project_ccla_requires_icla_signature() is True:
# cla.log.debug(f'{fn} - CCLA signature check - '
# 'project requires ICLA signature as well as CCLA signature ')
if user.is_approved(signature) :
ccla_pass = True
else:
# Set user signatures approved = false due to user failing whitelist checks
Expand Down

0 comments on commit b48c470

Please sign in to comment.