Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add old DPIF email #304

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add old DPIF email #304

merged 1 commit into from
Dec 16, 2024

Conversation

albertkol
Copy link
Contributor

Add old DPIF email.

@albertkol albertkol merged commit 1a5c197 into main Dec 16, 2024
15 checks passed
@albertkol albertkol deleted the add-old-dpif-email branch December 16, 2024 08:48
@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Dec 16, 2024 •
edited
Loading

This is because we still have some fund round configuration that references [email protected], and when that can't resolve in the lookup table we get errors in sentry.

✦4 ❯ ag "[email protected]" apps
apps/funding-service-pre-award-stores/fund_store/config/fund_loader_config/digital_planning/dpi_r2.py
142:        "contact_email": "[email protected]",

The uuid reference here is for the reply-to address of [email protected], so users would theoretically still see the correct address. That said - the round should be closed and we aren't totally sure how/why this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelhwilliams samuelhwilliams samuelhwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertkol @samuelhwilliams